Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on Android with gnustl #114

Merged
merged 1 commit into from
May 26, 2017
Merged

Fix build on Android with gnustl #114

merged 1 commit into from
May 26, 2017

Conversation

KindDragon
Copy link
Contributor

No description provided.

ondys
ondys reviewed May 25, 2017
View reviewed changes
Copy link
Collaborator

@ondys ondys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gnustl doesn't define std::log2 in ?

are you linking to the c++11 version of the library?

@KindDragon
Copy link
Contributor Author

KindDragon commented May 25, 2017 •
edited
Loading

gnustl doesn't define std::log2 in ?

Yes

are you linking to the c++11 version of the library?

Yes with -std=c++11

@ondys ondys merged commit 45712ff into google:master May 26, 2017
@ondys
Copy link
Collaborator

ondys commented May 26, 2017

Thanks for the PR. We will change it for now. Hopefully gnustl will add std::log2 soon.

@KindDragon KindDragon deleted the patch-1 branch May 26, 2017 16:11
@mekya
Copy link

mekya commented Nov 11, 2017

btw, for the release 1.2.0
options.h uses std::to_string and std::strtof functions which are not in gnustl

danielgronlund pushed a commit to danielgronlund/draco that referenced this pull request Aug 22, 2024
@KindDragon @ondys
Fix build on Android with gnustl (google#114)
5bfbfe1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondys ondys ondys left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KindDragon @ondys @mekya