[cmake] Re-fix the cmake config files #787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed. |
|
Any news here? |
|
Not yet, perhaps later in the week-- vcpkg support is not a project priority. |
Yeah vcpkg is not high pirority, but this is a bug. |
|
Closing this in favor of the changes in #796. At present I don't see a really good reason for using the export functionality to achieve what the addition of a find_library() call to the config file can handle. Please open a new issue if problems persist after the latest update to the CMake config file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue PR #775.
EXPORTinstead of hardcode.DRACO_LIB_DIR->DRACO_LIBRARY_DIR(See draco: Improve installation and packaging support. #775 comment).DRACO_FOUND.