Load py_library, py_binary from rules_python #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an explicit dependency on rules_python and loads py_library and py_binary rules from there, instead of relying on built-in versions in Bazel. This prepares us for the rollout of bazelbuild/bazel#15897 (which is happening internally already, and across the Bazel ecosystem soon). Except for the change to the WORKSPACE file, this change was auto-generated by running, buildozer 'new_load @rules_python//python:py_library.bzl py_library' //...:__pkg__ buildozer 'new_load @rules_python//python:py_binary.bzl py_binary' //...:__pkg__ buildozer 'new_load @rules_python//python:py_test.bzl py_test' //...:__pkg__ buildozer 'fix unusedLoads' //...:__pkg__ Upstreams cl/551628592.
robrussell
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an explicit dependency on rules_python and loads py_library and py_binary rules from there, instead of relying on built-in versions in Bazel.
Doing so prepares us for the rollout of
bazelbuild/bazel#15897 (which is happening internally already, and across the Bazel ecosystem soon).
Except for the change to the WORKSPACE file, this change was auto-generated by running,
Upstreams cl/551628592.