Fix an NPE in InvalidLink

Discovered while validating 2.4.0 release (#1639) ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=313487177
google · May 29, 2020 · 16b25b4 · 16b25b4
1 parent c085dc1
commit 16b25b4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/javadoc/InvalidLink.java b/core/src/main/java/com/google/errorprone/bugpatterns/javadoc/InvalidLink.java
@@ -141,6 +141,9 @@ public Void visitErroneous(ErroneousTree erroneousTree, Void unused) {
 
     @Override
     public Void visitLink(LinkTree linkTree, Void unused) {
+      if (linkTree.getReference() == null) {
+        return super.visitLink(linkTree, null);
+      }
       String reference = linkTree.getReference().getSignature();
       Element element = null;
       try {

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/javadoc/InvalidLinkTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/javadoc/InvalidLinkTest.java
@@ -157,4 +157,16 @@ public void multiField() {
             "}")
         .doTest();
   }
+
+  @Test
+  public void emptyLinkTest() {
+    helper
+        .addSourceLines(
+            "Test.java", //
+            "interface Test {",
+            "  /** {@link} */",
+            "  void foo();",
+            "}")
+        .doTest();
+  }
 }