Do the expensive bit last in UnusedMethod.

Healthier: [] PiperOrigin-RevId: 498170447
google · Dec 28, 2022 · 1d23141 · 1d23141
1 parent e360257
commit 1d23141
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnusedMethod.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnusedMethod.java
@@ -253,9 +253,7 @@ private boolean isMethodSymbolEligibleForChecking(
           return false;
         }
         MethodSymbol methodSymbol = getSymbol(tree);
-        if (!methodSymbol.isPrivate()
-            && classesMadeVisible.stream()
-                .anyMatch(t -> isSubtype(t.type, methodSymbol.owner.type, state))) {
+        if (!canBeRemoved(methodSymbol, state)) {
           return false;
         }
         if (isExemptedConstructor(methodSymbol, state)
@@ -271,8 +269,13 @@ private boolean isMethodSymbolEligibleForChecking(
             return false;
           }
         }
+        if (!methodSymbol.isPrivate()
+            && classesMadeVisible.stream()
+                .anyMatch(t -> isSubtype(t.type, methodSymbol.owner.type, state))) {
+          return false;
+        }
 
-        return canBeRemoved(methodSymbol, state);
+        return true;
       }
 
       private boolean isExemptedConstructor(MethodSymbol methodSymbol, VisitorState state) {