Suppress UnnecessarilyVisible findings on Error Prone bugchecker cons…

…tructors See #3706 (comment) PiperOrigin-RevId: 501041647
google · Jan 10, 2023 · 4a71fa8 · 4a71fa8
1 parent ef13837
commit 4a71fa8
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessarilyVisible.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessarilyVisible.java
@@ -26,6 +26,7 @@
 import static com.google.errorprone.util.ASTHelpers.findSuperMethod;
 import static com.google.errorprone.util.ASTHelpers.getSymbol;
 import static com.google.errorprone.util.ASTHelpers.hasDirectAnnotationWithSimpleName;
+import static com.google.errorprone.util.ASTHelpers.isSubtype;
 
 import com.google.common.collect.ImmutableSet;
 import com.google.errorprone.BugPattern;
@@ -93,6 +94,14 @@ public Description matchMethod(MethodTree tree, VisitorState state) {
     if (badModifiers.isEmpty()) {
       return NO_MATCH;
     }
+    // TODO(b/263227221): Remove this once migration to guice is complete
+    if (symbol.isConstructor()
+        && isSubtype(
+            symbol.enclClass().asType(),
+            state.getTypeFromString("com.google.errorprone.bugpatterns.BugChecker"),
+            state)) {
+      return NO_MATCH;
+    }
     return buildDescription(tree)
         .addFix(
             removeModifiers(tree.getModifiers(), state, badModifiers)

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessarilyVisibleTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessarilyVisibleTest.java
@@ -175,4 +175,18 @@ public void overridesPublicMethod_noFinding() {
         .expectUnchanged()
         .doTest();
   }
+
+  @Test
+  public void negativeBugchecker() {
+    compilationHelper
+        .addSourceLines(
+            "Test.java",
+            "import com.google.errorprone.bugpatterns.BugChecker;",
+            "import javax.inject.Inject;",
+            "class MyBugChecker extends BugChecker {",
+            "  @Inject",
+            "  public MyBugChecker() {}",
+            "}")
+        .doTest();
+  }
 }