Improve tests by using ExecutorService#submit to demonstrate inlini…

…ng type arguments
google · Dec 2, 2021 · 5538a86 · 5538a86
1 parent 949048d
commit 5538a86
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 11 deletions.
diff --git a/...ogle/errorprone/refaster/testdata/input/TypeArgumentsMethodInvocationTemplateExample.java b/...ogle/errorprone/refaster/testdata/input/TypeArgumentsMethodInvocationTemplateExample.java
@@ -14,10 +14,14 @@
 
 package com.google.errorprone.refaster.testdata;
 
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+
 /** Test data for {@code TypeArgumentsMethodInvocationTemplate}. */
 public class TypeArgumentsMethodInvocationTemplateExample {
-  public boolean example() {
-    String s = "";
-    return s.isEmpty();
+  public Future<Object> example() {
+    ExecutorService executorService = Executors.newSingleThreadExecutor();
+    return executorService.submit(() -> new Object());
   }
 }
diff --git a/...gle/errorprone/refaster/testdata/output/TypeArgumentsMethodInvocationTemplateExample.java b/...gle/errorprone/refaster/testdata/output/TypeArgumentsMethodInvocationTemplateExample.java
@@ -14,10 +14,14 @@
 
 package com.google.errorprone.refaster.testdata;
 
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+
 /** Test data for {@code TypeArgumentsMethodInvocationTemplate}. */
 public class TypeArgumentsMethodInvocationTemplateExample {
-  public boolean example() {
-    String s = "";
-    return s.<String>isEmpty();
+  public Future<Object> example() {
+    ExecutorService executorService = Executors.newSingleThreadExecutor();
+    return executorService.<Object>submit(() -> new Object());
   }
 }
diff --git a/...m/google/errorprone/refaster/testdata/template/TypeArgumentsMethodInvocationTemplate.java b/...m/google/errorprone/refaster/testdata/template/TypeArgumentsMethodInvocationTemplate.java
@@ -18,16 +18,19 @@
 
 import com.google.errorprone.refaster.annotation.AfterTemplate;
 import com.google.errorprone.refaster.annotation.BeforeTemplate;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Future;
 
 /** Sample template for introducing type arguments on a method invocation in an @AfterTemplate. */
-public class TypeArgumentsMethodInvocationTemplate {
+public class TypeArgumentsMethodInvocationTemplate<T> {
   @BeforeTemplate
-  boolean before(String string) {
-    return string.isEmpty();
+  Future<T> before(ExecutorService executorService, Callable<T> callable) {
+    return executorService.submit(callable);
   }
 
   @AfterTemplate
-  boolean after(String string) {
-    return string.<String>isEmpty();
+  Future<T> after(ExecutorService executorService, Callable<T> callable) {
+    return executorService.<T>submit(callable);
   }
 }