Don't flag module-info.java for not having default package

RELNOTES: Don't flag module-info.java for not having default package ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311760553
google · May 16, 2020 · 7be2c43 · 7be2c43
1 parent 40f1cae
commit 7be2c43
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/DefaultPackage.java b/core/src/main/java/com/google/errorprone/bugpatterns/DefaultPackage.java
@@ -18,6 +18,7 @@
 
 import static com.google.errorprone.BugPattern.SeverityLevel.WARNING;
 
+import com.google.common.io.Files;
 import com.google.errorprone.BugPattern;
 import com.google.errorprone.VisitorState;
 import com.google.errorprone.bugpatterns.BugChecker.CompilationUnitTreeMatcher;
@@ -53,6 +54,10 @@ public Description matchCompilationUnit(CompilationUnitTree tree, VisitorState s
     if (tree.getPackageName() != null) {
       return Description.NO_MATCH;
     }
+    // module-info.* is a special file name so whitelisting it.
+    if (Files.getNameWithoutExtension(ASTHelpers.getFileName(tree)).equals("module-info")) {
+      return Description.NO_MATCH;
+    }
     return describeMatch(tree);
   }
 }
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/DefaultPackageTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/DefaultPackageTest.java
@@ -16,6 +16,8 @@
 
 package com.google.errorprone.bugpatterns;
 
+import static org.junit.Assume.assumeTrue;
+
 import com.google.errorprone.CompilationTestHelper;
 import com.google.errorprone.util.RuntimeVersion;
 import org.junit.Test;
@@ -89,4 +91,16 @@ public void trailingComma() {
             "class T {};")
         .doTest();
   }
+
+  @Test
+  public void moduleInfo() {
+    assumeTrue(RuntimeVersion.isAtLeast9());
+
+    compilationHelper
+        .addSourceLines(
+            "module-info.java", //
+            "module testmodule {",
+            "}")
+        .doTest();
+  }
 }