Handle methods without parameters in ParameterComment

Fixes #707 MOE_MIGRATED_REVID=165665554
google · Aug 21, 2017 · 7edbf8d · 7edbf8d
1 parent 7eb9837
commit 7edbf8d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/ParameterComment.java b/core/src/main/java/com/google/errorprone/bugpatterns/ParameterComment.java
@@ -53,6 +53,9 @@ public class ParameterComment extends BugChecker implements MethodInvocationTree
   @Override
   public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState state) {
     MethodSymbol symbol = ASTHelpers.getSymbol(tree);
+    if (symbol.getParameters().isEmpty()) {
+      return NO_MATCH;
+    }
     SuggestedFix.Builder fix = SuggestedFix.builder();
     forEachPair(
         Comments.findCommentsForArguments(tree, state).stream(),

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ParameterCommentTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ParameterCommentTest.java
@@ -97,4 +97,19 @@ public void varargs() throws IOException {
             "}")
         .doTest(TestMode.TEXT_MATCH);
   }
+
+  @Test
+  public void noParams() throws IOException {
+    testHelper
+        .addInputLines(
+            "in/Test.java", //
+            "class Test {",
+            "  void f() {}",
+            "  {",
+            "    f();",
+            "  }",
+            "}")
+        .expectUnchanged()
+        .doTest();
+  }
 }