ASTHelpersSuggestions does not flag call to packge() on com.sun.tools.javac.code.Symbol.ClassSymbol

[msridhar]

I noticed that calls to packge() were not flagged by the new ASTHelpersSuggestions check when the static type of the receiver is com.sun.tools.javac.code.Symbol.ClassSymbol, which just inherits the packge() method from Symbol. I think this is because the check matches on the exact class Symbol:

error-prone/core/src/main/java/com/google/errorprone/bugpatterns/ASTHelpersSuggestions.java

Lines 43 to 46 in 80650f5

	private static final Matcher<ExpressionTree> SYMBOL =
	instanceMethod()
	.onExactClass("com.sun.tools.javac.code.Symbol")
	.namedAnyOf("isDirectlyOrIndirectlyLocal", "isLocal", "packge", "isStatic");

Was this intentional?

[graememorgan]

I've sent a PR to fix this internally, so I'll optimistically mark this as fixed in the next release.