JDK 9 support #448

dudaerich · 2016-08-17T12:10:28Z

When I try to compile my project using JDK 9 (https://jdk9.java.net/download/), I get following error.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project artemis-commons: Fatal error compiling: CompilerException: InvocationTargetException: java.nio.file.NotDirectoryException: /opt/jdk1.9.ea/lib/modules -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project artemis-commons: Fatal error compiling
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@9-ea/Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@9-ea/NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@9-ea/DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(java.base@9-ea/Method.java:535)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Fatal error compiling
    at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:796)
    at org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:129)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
    ... 20 more
Caused by: org.codehaus.plexus.compiler.CompilerException
    at org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne.performCompile(JavacCompilerWithErrorProne.java:95)
    at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:785)
    ... 23 more
Caused by: java.lang.reflect.InvocationTargetException
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@9-ea/Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@9-ea/NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@9-ea/DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(java.base@9-ea/Method.java:535)
    at org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne.performCompile(JavacCompilerWithErrorProne.java:91)
    ... 24 more
Caused by: java.io.UncheckedIOException: java.nio.file.NotDirectoryException: /opt/jdk1.9.ea/lib/modules
    at com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.lazy(Locations.java:725)
    at com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.isDefault(Locations.java:559)
    at com.sun.tools.javac.file.Locations.isDefaultBootClassPath(Locations.java:129)
    at com.sun.tools.javac.file.BaseFileManager.isDefaultBootClassPath(BaseFileManager.java:149)
    at com.sun.tools.javac.main.Arguments.validate(Arguments.java:411)
    at com.sun.tools.javac.main.Main.compile(Main.java:218)
    at com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:190)
    at com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:101)
    at com.google.errorprone.ErrorProneCompiler.run(ErrorProneCompiler.java:131)
    at com.google.errorprone.ErrorProneCompiler.compile(ErrorProneCompiler.java:73)
    at org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne$CompilerInvoker.compile(JavacCompilerWithErrorProne.java:219)
    ... 29 more
Caused by: java.nio.file.NotDirectoryException: /opt/jdk1.9.ea/lib/modules
    at sun.nio.fs.UnixFileSystemProvider.newDirectoryStream(java.base@9-ea/UnixFileSystemProvider.java:427)
    at java.nio.file.Files.newDirectoryStream(java.base@9-ea/Files.java:460)
    at java.nio.file.Files.list(java.base@9-ea/Files.java:3506)
    at com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.systemClasses(Locations.java:678)
    at com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.computePath(Locations.java:634)
    at com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.lazy(Locations.java:722)
    ... 39 more

The error-prone-javac assumes that $JAVA_HOME/lib/modules is a directory but in my case it is regular file. I use 1.9.0-dev-r2973-2 version of error-prone-javac.

The text was updated successfully, but these errors were encountered:

eaftan · 2016-08-17T17:41:23Z

We're not yet supporting running on JDK 9.

The current version of error-prone-javac was cut before Project Jigsaw (i.e. the module system) landed. It will require significant work for us to run on a modularized JDK. We are working on this internally, but it's low priority as the JDK 9 release date is more than 6 months away.

dudaerich · 2016-08-18T05:42:51Z

I see. Thank you for your response.

talios · 2017-02-16T02:29:09Z

WIth Java 9 coming later this year, I thought it'd be good to start occasionally tracking it with our builds, but hit this problem - any word on when some support might be available in error_prone?

eaftan · 2017-02-21T18:27:05Z

We still don't have a firm timeline for this. @cushon might have thoughts.

clebertsuconic · 2017-05-09T18:10:11Z

It's a bit weird to me you guys closing this issue without being fixed.. no plans to fix it?

we are using it on activemq artemis.. we may have to remove error prone otherwise we won't be able to move to jdk1.9.

cushon · 2017-05-09T18:13:04Z

Is this still happening with recent JDK 9 EA builds and Error Prone 2.0.20-SNAPSHOT?

clebertsuconic · 2017-05-09T18:18:40Z

I didn't try with a snapshot of Error Prone.. I can try it later today:

We were having a discussion here:

http://activemq.2283324.n4.nabble.com/DISCUSS-Artemis-JDK9-support-tp4725823.html;cid=1494353758727-471

if you want to be part of the discussion, you can subscribe to the dev list:

http://activemq.apache.org/mailing-lists.html

if you want to build it and try yourself:

https://github.com/apache/activemq-artemis/

a simple git clone and mvn install would do!

cushon · 2017-05-10T15:49:05Z

Let's leave this bug open to track JDK 9 support. I'm not sure we can commit to supporting JDK 9 before it's released, but it's definitely something we plan to do eventually.

@clebertsuconic I can build activemq-artemis with JDK 9-ea+168 and Error Prone 2.0.20-SNAPSHOT. I started with the fixes in ARTEMIS-683 and then re-enabled Error Prone.

-Xep:StaticAccessedFromInstance:ERROR needs to be updated to -Xep:StaticQualifiedUsingExpression:ERROR
I made a small change to Error Prone to work around JDK-8152842 that I'll submit soon
Error Prone reported a handful of new errors in the code that will need to be fixed or suppressed

java.annotations.common isn't provided by default in JDK 9, see https://bugs.openjdk.java.net/browse/JDK-8152842 This helps with #448 RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=155635468

…om/google/error-prone/compare/sync-master-05/10/2017 for better java 9 support, see google/error-prone#448 git-svn-id: https://josm.openstreetmap.de/svn/trunk@12243 0c6e7542-c601-0410-84e7-c038aed88b3b

…om/google/error-prone/compare/sync-master-05/10/2017 for better java 9 support, see google/error-prone#448 git-svn-id: http://josm.openstreetmap.de/svn/trunk@12243 0c6e7542-c601-0410-84e7-c038aed88b3b

ErrorProne is not compatible with JDK9, so the default compiler is used when compiling with JDK9. See google/error-prone#448.

cushon · 2017-10-13T15:45:03Z

Error Prone should run on JDK 9 now (see the "Java 9" section http://errorprone.info/docs/installation for instructions). If anyone encounters issues using it from the command line that way, please let us know.

We haven't done as much testing of the build system integrations: Bazel will work soon, there's an issue open for gradle (tbroyer/gradle-errorprone-plugin/issues/27), and I'm not sure about maven yet.

Support for using the Java 9 language level (not just running the tool on JDK 9) is work in progress.

mkarg · 2017-12-10T13:28:29Z

@cushon Can you please post the issue ID for the Java 9 language features? So one could track progress of that. :-)

novalis · 2018-05-16T02:16:00Z

The ant integration is broken for JDK 9 because (at least) of this line:
https://github.com/google/error-prone/blob/master/ant/src/main/java/com/google/errorprone/ErrorProneExternalCompilerAdapter.java#L93

-XbootClasspath/p isn't supported in Java 9, and the error-prone installation instructions recommend a different integration method for Java 9.

cushon · 2018-08-10T05:07:10Z

We need up update the rest of the build system installation docs to mention the -Xplugin integration, but Java 9, 10, and 11 are supported now: #860

eaftan closed this as completed Aug 17, 2016

tbroyer mentioned this issue Aug 23, 2016

JDK9 support tbroyer/gradle-errorprone-plugin-v0.0.x#27

Closed

cushon changed the title ~~NotDirectoryException when jdk-9-ea+131 is used~~ JDK 9 support May 10, 2017

cushon reopened this May 10, 2017

benoitf mentioned this issue Jun 28, 2017

Java 9 Support eclipse-che/che#5326

Closed

14 tasks

floscher added a commit to JOSM/Mapillary that referenced this issue Sep 16, 2017

Only use ErrorProne when building with JDK8

433da34

ErrorProne is not compatible with JDK9, so the default compiler is used when compiling with JDK9. See google/error-prone#448.

floscher added a commit to JOSM/Mapillary that referenced this issue Sep 16, 2017

Only use ErrorProne when building with JDK8

3482975

ErrorProne is not compatible with JDK9, so the default compiler is used when compiling with JDK9. See google/error-prone#448.

jbduncan mentioned this issue Sep 30, 2017

Enable error-prone static analysis checks junit-team/junit5#961

Closed

7 tasks

jbduncan mentioned this issue Nov 3, 2017

CheckReturnValue: support more variants of "fail" in try/execute/fail/catch #804

Closed

ChristianMurphy mentioned this issue Nov 15, 2017

[WIP] Java 10 Support uPortal-Project/uPortal#1007

Closed

8 tasks

cushon closed this as completed Aug 10, 2018

tbroyer mentioned this issue Sep 2, 2018

JDK 14/15 compatibility #1106

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK 9 support #448

JDK 9 support #448

dudaerich commented Aug 17, 2016

eaftan commented Aug 17, 2016

dudaerich commented Aug 18, 2016

talios commented Feb 16, 2017

eaftan commented Feb 21, 2017

clebertsuconic commented May 9, 2017 •

edited

Loading

cushon commented May 9, 2017

clebertsuconic commented May 9, 2017 •

edited

Loading

cushon commented May 10, 2017

cushon commented Oct 13, 2017

mkarg commented Dec 10, 2017

novalis commented May 16, 2018

cushon commented Aug 10, 2018

JDK 9 support #448

JDK 9 support #448

Comments

dudaerich commented Aug 17, 2016

eaftan commented Aug 17, 2016

dudaerich commented Aug 18, 2016

talios commented Feb 16, 2017

eaftan commented Feb 21, 2017

clebertsuconic commented May 9, 2017 • edited Loading

cushon commented May 9, 2017

clebertsuconic commented May 9, 2017 • edited Loading

cushon commented May 10, 2017

cushon commented Oct 13, 2017

mkarg commented Dec 10, 2017

novalis commented May 16, 2018

cushon commented Aug 10, 2018

clebertsuconic commented May 9, 2017 •

edited

Loading

clebertsuconic commented May 9, 2017 •

edited

Loading