-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FallThrough resilient to missing source information. #1174
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Update the FallThrough check to gracefully handle missing source code information, which occurs when using certain Lombok annotations. This is similar to the existing workaround added to the ParameterName bug pattern. Fixes #613.
CLAs look good, thanks! |
@cushon / @ronshapiro - Are you able to review this PR? |
Do you have a test? Have you seen this happen in builds that don't use lombok? |
This only occurs in builds that use Lombok from my experience. This is the same change made in #1135 just in another check we've found which fails without this information. |
int caseEndPositionIndex = caseEndPosition(state, caseTree); | ||
int nextStartPositionIndex = next.getStartPosition(); | ||
// best effort work-around for https://github.com/google/error-prone/issues/613 | ||
if (caseEndPositionIndex == Position.NOPOS || nextStartPositionIndex == Position.NOPOS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you see examples where next.getStartPosition()
wasn't available, or just caseEndPosition(state, caseTree)
?
I think this is subsumed by #1573. |
Closing since I think this will be fixed by #1573. |
Update the FallThrough check to gracefully handle missing source code
information, which occurs when using certain Lombok annotations. This is
similar to the existing workaround added to the ParameterName bug
pattern.
Fixes #613.