MOE Sync 2020-05-14 #1614
MOE Sync 2020-05-14 #1614
Conversation
Fixes #1590 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311374509
Fixes this warning: Fixes #1558 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311374636
(e.g. Lombok) Fixes #1573 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311375182
The first sentence says @injected and the second one says @Inject'ed. Change the first one to @Inject'ed so it's consistent. Change-Id: Id2ab8908a608288739af33cddc902f94707b057a Fixes #1491 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311375711
This property is never null and the caller unconditionally dereferences Fixes #1606 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311377788
This fix prevents reports such as the following, which are hard to debug for users: ``` [INFO] /path/to/some/File.java: [<no match>] <no match> (see <no match>) Fixes #1609 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311378177
Fixes #1591 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311388529
Closes #1325 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311412118
Many projects use the default import ordering provided by IntelliJ IDEA. In order to apply Error Prone without adjusting this ordering, one can Fixes #1208 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311437867
…ctoringTestHelper instances See e.g. #1313 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311470656
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311485962
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311510837
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
Could it be that there's a bug in MOE (?) which prevents the last line of the original PR from being mirrored out? Seems to apply to all of my most recent PRs (didn't check further back):
|
|
(Note that is also the cause of the malformed PR summary: because the monospace markdown block isn't closed it encompasses the description of all commits after it.) |
|
Just a last example of a PR not by me:
|
|
Interesting @Stephan202 - hmmm, any ideas @cpovirk ? |
|
...huh. Sorry, and thanks for letting me know. I had even seen that at one point but failed to look into it. For some inexplicable reason, the script I hacked up runs part of the patch through |
|
Tnx! (Are you perhaps a (Though in this case it must have been |
|
I am, and I have definitely hit ctrl+a once or twice in my time :) I also enjoy creating files named I suspect that what happened here is that I mentally mixed together |
|
Ah yes, I always need to do a "dry run" of those, cause I can never seem remember exactly how the parameter to |
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
fix typo
Fixes #1590
4386471
skip unnecessary boxing
Fixes this warning:
Fixes #1558
90197b0
Minor fix to FallThrough to skip generated/mutated AST nodes (e.g. Lombok)
Fixes #1573
1534bae
Make summary of InjectOnConstructorOfAbstractClass consistent
The first sentence says @injected and the second one says @Inject'ed.
Change the first one to @Inject'ed so it's consistent.
Change-Id: Id2ab8908a608288739af33cddc902f94707b057a
Fixes #1491
0839737
Drop `@Nullable` from `RefasterRule#afterTemplates()`
This property is never null and the caller unconditionally dereferences
Fixes #1606
87d4fe5
Handle `NO_MATCH` in `VisitorState#reportMatch` instead of `Scanner
This fix prevents reports such as the following, which are hard to debug
for users: