MOE Sync 2020-05-26 #1635
Merged
MOE Sync 2020-05-26 #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They've been deprecated since 2018 and are incompatible with JDK 15. #1106 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=313252393
#1106 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=313258773
to avoid writing annotation processing generated sources to the root of the source tree. (Currently running the tests leaves an AutoValue-generated file behind.) ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=313264950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Delete ErrorProneCompiler and BaseErrorProneCompiler
They've been deprecated since 2018 and are incompatible with JDK 15.
#1106
6756588
Use a getter instead of accessing a field on JCInstance
#1106
0206396
Set output directories in BugCheckRefactoringTestHelper
to avoid writing annotation processing generated sources to the root of the
source tree. (Currently running the tests leaves an AutoValue-generated file
behind.)
288c901