Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that -XDshould-stop.ifError=FLOW is set when running Error Prone #4618

Merged
merged 1 commit into from
Oct 15, 2024

Commits on Oct 15, 2024

  1. Check that -XDshould-stop.ifError=FLOW is set when running Error Prone

    This is necessary to ensure javac compiles the 'flow' phase for subsequent compilation units after Error Prone reports diagnostics. The 'flow' phase is necessary among other things to set `EFFECTIVELY_FINAL`. Configuring a later stop policy also causes more diagnostics to be shown at once for failing builds when using `-XDcompilePolicy=simple`, which is helpful.
    
    #4595
    
    RELNOTES=The javac flag `-XDshould-stop.ifError=FLOW` is now required when running Error Prone, see #4595
    PiperOrigin-RevId: 686102738
    cushon authored and Error Prone Team committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5828416 View commit details
    Browse the repository at this point in the history