Add a check for redundant continue statements. #4667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_694218798
branch
5 times, most recently
from
b2069d4 to
8ea5526
Compare
I gave it a suitably generic name in case we generalise in the future. I'm curious about redundant trailing `return;`s from methods! Flume: unknown commit I didn't spot any obvious _bugs_ looking through, though of course it's hard to tell. PiperOrigin-RevId: 696892282
copybara-service
bot
force-pushed
the
test_694218798
branch
from
8ea5526 to
947e77e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check for redundant continue statements.
I gave it a suitably generic name in case we generalise in the future. I'm curious about redundant trailing
return;s from methods!Flume: unknown commit
I didn't spot any obvious bugs looking through, though of course it's hard to tell.