Fix edge case in InconsistentCapitalization
#4801
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
InconsistentCapitalization
does not handle well the case that the class has multiple fields with names that are equivalent except for capitalization.For example, the following code
results in an error
On the other hand, if the order of the fields is swapped, there is no match.
This proposed change improves the behaviour for this edge case, so that the order in which the fields are declared no longer matters. The new behaviour is that a parameter is a match if there is at least one field that is equivalent except for capitalization, but no field matches exactly.