Add RedundantNullCheck bug pattern. #5253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RedundantNullCheck bug pattern.
Closes #5107.
A null check is redundant if it is performed on a variable or method call that is known to be non-null within a
@NullMarkedscope.Within a
@NullMarkedscope, types are non-null by default unless explicitly annotated with@Nullable.Therefore, checking a variable or method return value (that isn't
@Nullable) for nullness is unnecessary, as it should never be null.Example:
This check helps to clean up code and reduce clutter by removing unnecessary null checks, making the code easier to read and maintain.
It also reinforces the contract provided by
@NullMarkedand@Nullableannotations.Fixes #5121
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5121 from bdragan:5107-redundant_null_check f935970