Re-throw FHIR client exceptions #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1112 +/- ##
=========================================
Coverage 51.78% 51.78%
Complexity 669 669
=========================================
Files 95 95
Lines 5577 5577
Branches 724 724
=========================================
Hits 2888 2888
Misses 2410 2410
Partials 279 279 ☔ View full report in Codecov by Sentry. |
jakubadamek
added a commit
to jakubadamek/fhir-data-pipes
that referenced
this pull request
Jul 6, 2024
|
@chandrashekar-s I like to close this PR and #1109 too; can you please take a look. The real underlying issue is this on the HAPI side but the specific issue of "missing resources" should be fixed by this. |
pipelines/batch/src/main/java/com/google/fhir/analytics/FhirSearchUtil.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
This fixes #1109; see this comment for details.
E2E test
TESTED:
Relied on unit/e2e tests but will also ask @jakubadamek to test this in his load-testing environment.
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master