Fix KTX texture format for latest version #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! We should also remove the last case in the switch in toPixelDataFormat in |
prideout
suggested changes
Jul 22, 2020
prideout
approved these changes
Jul 22, 2020
romainguy
reviewed
Jul 22, 2020
| @@ -933,7 +933,7 @@ void iblRoughnessPrefilter( | |||
| .endianness = KtxBundle::ENDIAN_DEFAULT, | |||
| .glType = KtxBundle::R11F_G11F_B10F, | |||
| .glTypeSize = 1, | |||
| .glFormat = KtxBundle::R11F_G11F_B10F, | |||
There was a problem hiding this comment.
Why was this removed? We need this format for our IBLs. It breaks all environment lighting.
There was a problem hiding this comment.
We're still using the 11_11_10 (see the glType field), this needed to be unsized to be valid KTX. Is stuff breaking for you?
There was a problem hiding this comment.
Actually the issue isn't here. The issue is above.
romainguy
reviewed
Jul 22, 2020
| @@ -933,7 +933,7 @@ void iblRoughnessPrefilter( | |||
| .endianness = KtxBundle::ENDIAN_DEFAULT, | |||
| .glType = KtxBundle::R11F_G11F_B10F, | |||
| .glTypeSize = 1, | |||
| .glFormat = KtxBundle::R11F_G11F_B10F, | |||
There was a problem hiding this comment.
Actually the issue isn't here. The issue is above.
| @@ -227,7 +227,6 @@ namespace ktx { | |||
| case KtxBundle::RG: return PixelDataFormat::RG; | |||
| case KtxBundle::RGB: return PixelDataFormat::RGB; | |||
| case KtxBundle::RGBA: return PixelDataFormat::RGBA; | |||
| case KtxBundle::R11F_G11F_B10F: return PixelDataFormat::RGB; | |||
There was a problem hiding this comment.
Removing this line breaks compatibility with existing assets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The *_ibl.ktx and *_skybox.ktx files generated by cmgen cannot be read in the latest KTX release (v4.0.0-beta3). This is because
glFormatshould be unsized, according to spec (so it should be RGB).