Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Prepare Shadow Pass" was never executed #5881

Merged
merged 1 commit into from
Aug 3, 2022
Merged

The "Prepare Shadow Pass" was never executed #5881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions filament/src/ShadowMapManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,9 @@ FrameGraphId<FrameGraphTexture> ShadowMapManager::render(FrameGraph& fg, FEngine
.type = SamplerType::SAMPLER_2D_ARRAY,
.format = view.hasVSM() ? vsmTextureFormat : mTextureFormat
});
// This pass must be declared as having a side effect because it never gets a
// "read" from one of its resource (only writes), so the FrameGraph culls it.
builder.sideEffect();
},
[&view](FrameGraphResources const& resources, auto const& data, DriverApi& driver) {
// set uniforms needed to render this ShadowMap
Expand Down