Do not assert for certain custom CONFIG values. #5921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Developers who know their users have powerful devices can exceed minspec constraints by adjust CONFIG_MAX_BONE_COUNT and/or CONFIG_MAX_MORPH_TARGET_COUNT. If they do this, they should not hit a `static_asset`. Fixes #5785.
|
Please add a release note line to RELEASE_NOTES.md. If this PR does not warrant a release note, add the 'internal' label to this PR. |
bejado
reviewed
Aug 15, 2022
|
|
||
| // ES3.0 only guarantees a max UBO size of 16 KiB, but users may wish to exceed the minspec | ||
| // by adjusting CONFIG_MAX_BONE_COUNT. | ||
| static_assert(sizeof(PerRenderableBoneUib) == CONFIG_MAX_BONE_COUNT * 64, |
There was a problem hiding this comment.
Maybe replace 64 with sizeof(BoneData)? That makes me question if we really need this assertion now
Similar suggestion for the morph targets.
pixelflinger
requested changes
Aug 15, 2022
Comment on lines
+294
to
+295
| static_assert(sizeof(PerRenderableBoneUib) == CONFIG_MAX_BONE_COUNT * 64, | ||
| "PerRenderableUibBone has unexpected size"); |
There was a problem hiding this comment.
This assert becomes a bit useless because the structure itself is an array of CONFIG_MAX_BONE_COUNT.
The point of this assert was to make sure to not set a CONFIG_MAX_BONE_COUNT that would exceed the minspec we support.
So I think the better/correct solution is to introduce a CONFIG_MINSPEC_UBO_SIZE constant the developers can adjust. Same for CONFIG_MAX_MORPH_TARGET_COUNT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers who know their users have powerful devices can exceed
minspec constraints by adjust CONFIG_MAX_BONE_COUNT and/or
CONFIG_MAX_MORPH_TARGET_COUNT. If they do this, they should not
hit a
static_asset.Fixes #5785.