Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preferredShaderLanguage option to Engine::Config #7816

Merged
merged 3 commits into from
May 6, 2024
Merged

Add preferredShaderLanguage option to Engine::Config #7816

merged 3 commits into from
May 6, 2024

Conversation

bejado
Copy link
Member

@bejado bejado commented May 1, 2024 •
edited
Loading

BUGS=[338287719]

pixelflinger
pixelflinger requested changes May 2, 2024
View reviewed changes
filament/include/filament/Engine.h Outdated Show resolved Hide resolved
filament/include/filament/Engine.h Outdated Show resolved Hide resolved
@bejado bejado requested a review from pixelflinger May 3, 2024 18:47
@bejado bejado merged commit a1752b3 into main May 6, 2024
10 checks passed
@bejado bejado deleted the bjd/preferred-shader-language branch May 6, 2024 19:12
poweifeng pushed a commit that referenced this pull request May 6, 2024
@bejado @poweifeng
Add preferredShaderLanguage option to Engine::Config (#7816)
2d157e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflinger pixelflinger pixelflinger approved these changes

@z3moon z3moon Awaiting requested review from z3moon

@poweifeng poweifeng Awaiting requested review from poweifeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bejado @pixelflinger