matdbg: fix three bugs #8430
Merged
matdbg: fix three bugs #8430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. changes weren't refreshed for windows/linux-mesa vulkan. This is due to a reordering of the shaders when the shader source is replaced. We fix this by ensuring the ordering before writing out the edit. Fixes #7286 2. A condition was flipped in the SourceFormatter causing the format feature to not work on linux 3. The material update status wasn't really propagated to the front-end due to not updating the status counter.
z3moon
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes weren't refreshed for windows/linux-mesa vulkan. This is due to a reordering of the shaders when the shader source is replaced. We fix this by ensuring the ordering before writing out the edit. Fixes matdbg is not properly refreshed for Vulkan backend on windows/linux #7286
A condition was flipped in the SourceFormatter causing the format feature to not work on linux
The material update status wasn't really propagated to the front-end due to not updating the status counter.