Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Python release to avoid Deprecation Warning #6957

Closed
MarcoGorelli opened this issue Nov 25, 2021 · 11 comments
Closed

New Python release to avoid Deprecation Warning #6957

MarcoGorelli opened this issue Nov 25, 2021 · 11 comments

Comments

@MarcoGorelli
Copy link

MarcoGorelli commented Nov 25, 2021

The latest Python release shows a DeprecationWarning:

E   DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses

This was fixed in #6362 - any chance a new release could be made, so the warning will go away?


Edit: apologies for having asked, I now understand that it's rude to ask for new releases

@aardappel
Copy link
Collaborator

We don't typically make releases just because something improved for one language, we'd end up with a release each commit :)

I recommend using the latest master instead of a last release.

@MarcoGorelli
Copy link
Author

sure, thanks

@cool-RR
Copy link

cool-RR commented May 22, 2022

@aardappel It's been 6 months, and this DeprecationWarning is still a nuisance. Could you make a new release soon please?

@aardappel
Copy link
Collaborator

@cool-RR see my last comment.

@johnthagen
Copy link

The imp module will be removed in Python 3.12.

Given that Python 3.11 recently entered beta, this means that very soon flatbuffers may not work on the latest Python development branch.

@teunFTW
Copy link

teunFTW commented Jun 8, 2022

@aardappel I agree with with @cool-RR that it would be really nice if a new release could be made soon! :)

@oscarbenjamin
Copy link

It's been over 12 months since #6362 was merged. Are there any plans to make a release soon?

@NeilGirdhar
Copy link
Contributor

NeilGirdhar commented Jul 14, 2022

@aardappel

We don't typically make releases just because something improved for one language, we'd end up with a release each commit :)

Your point is reasonable. However, no one is asking for a release for each commit. I think it's more than fair to expect a release every year to solve deprecation warnings.

We do want to be respectful of your valuable time. However, I invested my time in the pull request in the hopes that it would solve this problem for me and other users. #6362

I recommend using the latest master instead of a last release.

That's not a reasonable suggestion since pinning a requirement to master is bad practice.

@aardappel
Copy link
Collaborator

That's not a reasonable suggestion since pinning a requirement to master is bad practice.

I didn't get that memo.

Either way, up to @dbaileychess when a new release happens.

@NeilGirdhar
Copy link
Contributor

I didn't get that memo.

The reason pinning to master is usually considered bad is because it exposes you to untested combinations. How should you know that a future version master is compatible with your current version? You can't. Typically, you pin to a minor version, with reasonable assurance that everything will keep working within the same minor version.

Another problem with pinning to master is that it is three times the work for everyone. In this case, we would have to convince tensorflow to pin flatbuffers to master, and wait for their release. And then when flatbuffers releases tensorflow will have to restore the flatbuffers pin. That's three steps instead of flatbuffers releasing.

@tbenthompson
Copy link

I get a DeprecationWarning whenever I import jax. The underlying reason is that this release hasn't happened yet. I would be very grateful for a release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants