Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence pillow deprecation warnings #11173

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Conversation

indam23
Copy link
Contributor

@indam23 indam23 commented Jun 7, 2022

Proposed changes:

  • Silence warnings about deprecated Pillow methods generated by keras-preprocessing

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@indam23 indam23 changed the base branch from main to 3.1.x June 7, 2022 11:19
@indam23 indam23 marked this pull request as ready for review June 7, 2022 11:19
@indam23 indam23 requested a review from a team as a code owner June 7, 2022 11:19
@indam23 indam23 requested review from losterloh and a team and removed request for a team June 7, 2022 11:19
losterloh
losterloh approved these changes Jun 7, 2022
@indam23
Copy link
Contributor Author

indam23 commented Jun 7, 2022

The imp one is an odd one, the library generating the warning is flatbuffers, and on Github they fixed the import in 2.0.5 but PyPi stops at 2.0.0. We can add the warning to expected warnings, but I think the better way would be to upgrade the package, if possible.

@indam23
Copy link
Contributor Author

indam23 commented Jun 7, 2022

Reading google/flatbuffers#4507 & google/flatbuffers#6957 I've concluded that no, it's not going to be possible to upgrade the package because the maintainers don't do regular pypi releases. I'll add the warning to the expected ones.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

🚀 A preview of the docs have been deployed at the following URL: https://11173--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@indam23 indam23 merged commit 0c9d457 into 3.1.x Jun 8, 2022
@indam23 indam23 deleted the ATO-139-reduce-logging-noise⚡ branch June 8, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants