Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port FlatBuffers to Go. #36

Closed
wants to merge 1 commit into from
Closed

Port FlatBuffers to Go. #36

wants to merge 1 commit into from

Conversation

rw
Copy link
Collaborator

@rw rw commented Jul 11, 2014

Implement code generation and runtime library for Go, derived from the
Java implementation. Additionally, the test suite verifies:

  • the exact bytes in the Builder buffer during object construction,
  • vtable deduplication, and
  • table construction, via a fuzzer derived from the C++ implementation.

@rw
Copy link
Collaborator Author

rw commented Jul 11, 2014

Unlike the Java version, the Go port does not overwrite data when deduplicating vtables. This is a step towards basing Builder on io.Writer, instead of a byte slice, for better generality.

@rw
Copy link
Collaborator Author

rw commented Jul 12, 2014

I've force-pushed some small updates: code cleanup in go_test.go and removing all unnecessary calls to panic.

@rw rw mentioned this pull request Jul 12, 2014
Implement code generation and runtime library for Go, derived from the
Java implementation. Additionally, the test suite verifies:

 - the exact bytes in the Builder buffer during object construction,
 - vtable deduplication, and
 - table construction, via a fuzzer derived from the C++ implementation.
@ghost
Copy link

ghost commented Jul 28, 2014

This commit is in thru a cherry-pick.

@ghost ghost closed this Jul 28, 2014
@rw
Copy link
Collaborator Author

rw commented Jul 31, 2014

The cherry-picked commit is: 74d5f37

@rw rw deleted the go-port branch July 31, 2014 06:48
kakikubo pushed a commit to kakikubo/flatbuffers that referenced this pull request Apr 19, 2016
…_erase

support erased element and accessors for dirty
@jeroenrinzema
Copy link

@rw Are there still plans to support writing to an io.Writer instead of a byte buffer?

@rw
Copy link
Collaborator Author

rw commented Dec 27, 2020

@jeroenrinzema No plans for that at the moment. I think the builder algorithm prevents using an io.Writer directly (because it builds back to front). I can imagine us creating some kind of writer interface that would encapsulate the builder buffer logic, though (we could call it a BackToFrontWriter).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants