Python: CreateByteVector function in builder. #4453
Merged
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! LGTM. I think there may be another out-standing issue or PR that was also asking for this. |
|
It's not tested as much as |
|
@jfinken Does this meet your needs? |
|
Wonderful. Many thanks for the swift response and the PR. It does indeed meet my needs. On my setup the serialization time for data that included the byte vector went from ~120.40ms down to ~0.27ms. |
|
@jfinken Glad to hear it! |
kbrose
reviewed
Oct 24, 2017
| @@ -421,6 +421,27 @@ def CreateString(self, s, encoding='utf-8', errors='strict'): | |||
|
|
|||
| return self.EndVector(len(x)) | |||
|
|
|||
| def CreateByteVector(self, x): | |||
| """CreateString writes a byte vector.""" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
CreateByteVectorfunction to the PythonBuilder. This handles the write path for byte vectors (we already handle the read path).