Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vcpkg installation instructions #5732

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

PhoebeHui
Copy link
Contributor

Flatbuffers is available as a port in VCPKG , documenting the install process here will help users get started by providing a single set of commands to build flatbuffers, ready to be included in their projects.

VCPKG is a C++ library manager that simplifies installation for flatbuffers and other project dependencies, we also test whether our library ports build in various configurations (dynamic, static) on various platforms (OSX, Linux, Windows: x86, x64, UWP, ARM) to keep a wide coverage for users.

I'm a maintainer for vcpkg, and here is what the port script looks like. We try to keep the library maintained as close as possible to the original library.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@PhoebeHui
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@PhoebeHui
Copy link
Contributor Author

@googlebot I fixed it.

1 similar comment
@PhoebeHui
Copy link
Contributor Author

@googlebot I fixed it.

@PhoebeHui
Copy link
Contributor Author

@googlebot I fixed it.

@PhoebeHui
Copy link
Contributor Author

I'm sure why the cla failed, I signed the cla, also updated my contact email with the account that Github used, additionally configured my gmail on GitHub account.

@aardappel
Copy link
Collaborator

Thanks! VCPKG is awesome, hope it becomes the standard for C++, so happy to support :)

Not sure about CLA either..

@aardappel aardappel merged commit bab2b0d into google:master Jan 23, 2020
LuckyRu pushed a commit to LuckyRu/flatbuffers that referenced this pull request Oct 2, 2020
* Add vcpkg installation instructions

* Update comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants