Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved various language tests from AppVeyor to GitHub Actions #6300

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

aardappel
Copy link
Collaborator

No description provided.

@aardappel aardappel force-pushed the master branch 2 times, most recently from f44225c to de718a5 Compare November 30, 2020 20:59
@aardappel
Copy link
Collaborator Author

@krojew looks like JS/TS not happy in this new CI, any hints what I should fix? Also curious the TS one succeeds, but looks like it shouldn't.

@dbaileychess the C# one also succeeds but looks like it shouldn't

@aardappel
Copy link
Collaborator Author

@rw can't get the Go test to work, without my changes it complains about a flag that was defined that was not passed, which appears to be caused by golang/go#31859

@krojew
Copy link
Contributor

krojew commented Dec 1, 2020

I think JS/TS problems can be related to the discussion here: #6145 We should move away for a monolithic lib in favor of modules and transpilation.

@aardappel
Copy link
Collaborator Author

Ok, I think what I'll do is disable the failing languages for now, and they can be addressed at some future date.

There is already value in the current PR in having reduced the scope of our dependence on AppVeyor (and hopefully making it run faster), giving languages their own CI, and even adding CI for languages we didn't have before.

For anyone that ends up enabling CI for a particular language: make sure to remove it from the AppVeyor script if we are covering it completely. My goal is eventually to get rid of AppVeyor CI entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants