[go] tests/GoTest.sh: Fix flags.Parse location to work on new go SDKs. #6388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling flags.Parse() within init() races with other packages which register flags in their init(), and in particular with the testing package itself. It is more reliable to call flags.Parse() from a TestMain implementation. See golang/go#31859, golang/go#33869.
reltuk
changed the title
|
Before this change, I get this when trying to run the tests: aaronson@Aarons-MacBook-Pro tests % go version
go version go1.15.5 darwin/amd64
aaronson@Aarons-MacBook-Pro tests % ./GoTest.sh
flag provided but not defined: -test.timeout
Usage of /var/folders/zj/r1b6gjbx1vn5rxvyf8tzsldm0000gn/T/go-build819444557/b001/flatbuffers_test.test:
-cpp_data string
location of monsterdata_test.mon to verify against (required)
-fuzz
perform fuzzing
-fuzz_fields int
fields per fuzzer object (default 4)
-fuzz_objects int
number of fuzzer objects (higher is slower and more thorough (default 10000)
-java_data string
location of monsterdata_java_wire.mon to verify against (optional)
-out_data string
location to write generated Go data
-quickchecks int
The default number of iterations for each check (default 100)
exit status 2
FAIL flatbuffers_test 0.069s
FAIL |
reltuk
commented
Jan 7, 2021
| @@ -47,11 +47,11 @@ cp -a ./go_test.go ./go_gen/src/flatbuffers_test/ | |||
| # flag -test.bench and the wildcard regexp ".": | |||
| # go -test -test.bench=. ... | |||
| GOPATH=${go_path} go test flatbuffers_test \ | |||
| --test.coverpkg=github.com/google/flatbuffers/go \ | |||
| --coverpkg=github.com/google/flatbuffers/go \ | |||
There was a problem hiding this comment.
This was necessary for me...test.coverpkg was reported as not registered. I'm not sure if go test itself interprets the flag as part of compilation and doesn't actually pass it along to the test binary or something.
--bench and --benchtime below were changed for consistency, but I'm also happy to change them back. It works either way for me.
|
Thanks! can you enable the |
|
Yay, working Go CI, thanks! :) |
|
That's awesome. Thanks for quick turn around! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling flags.Parse() within init() races with other packages which register
flags in their init(), and in particular with the testing package itself. It is
more reliable to call flags.Parse() from a TestMain implementation.
See golang/go#31859,
golang/go#33869.