[TS] Fixes GRPC code #6441
Merged
[TS] Fixes GRPC code #6441
+310
−288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should also land in #6353 |
|
@bjornharrtell is it always guarantied that the generated TS file will always only contain one Table/struct? |
|
@mustiikhalil yes, at least that is the intention. |
mustiikhalil
commented
Feb 4, 2021
Comment on lines
2
to
6
| import { flatbuffers } from 'flatbuffers'; | ||
| import * as Greeter_fbs from './greeter_generated'; | ||
| import { HelloReply as Welcome_HelloReply } from './welcome/hello-reply'; | ||
| import { HelloRequest as Welcome_HelloRequest } from './welcome/hello-request'; | ||
|
|
||
| import * as grpc from 'grpc'; |
There was a problem hiding this comment.
Is this okay to do? since I am not really sure how the new imports actually work
mustiikhalil
commented
Feb 4, 2021
Comment on lines
32
to
+48
|
|
||
| grpc::string ToDasherizedCase(const grpc::string pascal_case) { | ||
| std::string dasherized_case; | ||
| char p = 0; | ||
| for (size_t i = 0; i < pascal_case.length(); i++) { | ||
| char const &c = pascal_case[i]; | ||
| if (flatbuffers::is_alpha_upper(c)) { | ||
| if (i > 0 && p != flatbuffers::kPathSeparator) dasherized_case += "-"; | ||
| dasherized_case += flatbuffers::CharToLower(c); | ||
| } else { | ||
| dasherized_case += c; | ||
| } | ||
| p = c; | ||
| } | ||
| return dasherized_case; | ||
| } | ||
|
|
There was a problem hiding this comment.
Took this code from BaseGenerator.
|
@bjornharrtell can you please take a look at this PR if you have time. just to see if it won't have any conflicts with the huge rework the TS language had |
17 tasks
|
Can't review in detail but what I see looks ok to me. |
|
Looks good. |
Fixes issues with namespaces in grpc ts Renamed welcome -> models
mustiikhalil
force-pushed
the
ts-grpc-fix
branch
from
6c3d30d to
f4e75b3
Compare
mustiikhalil
force-pushed
the
ts-grpc-fix
branch
from
781bc01 to
f4e75b3
Compare
|
Should I merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR fixes the TS code generator for GRPC to adhere to the new changes introduced in #6302.