Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift] Fixes grammer #6477

Merged
merged 1 commit into from
Feb 19, 2021
Merged

[Swift] Fixes grammer #6477

merged 1 commit into from
Feb 19, 2021

Conversation

mustiikhalil
Copy link
Collaborator

@mustiikhalil mustiikhalil commented Feb 19, 2021 •
edited
Loading

This pr changes the language on the create Constructor from offsetOfName to nameOffset.

Monster.createMonster(builder, nameOffset: nameOffset, testarrayofboolsVector: vector)

@github-actions github-actions bot added c++ codegen Involving generating code from schema swift labels Feb 19, 2021
@mustiikhalil
Copy link
Collaborator Author

This ofc is a small improvement before #6353

@mustiikhalil
Copy link
Collaborator Author

PR is ready to be merged, just ci is broken for rust

Fixes grammer
f756dc8 
Updates docs
@github-actions github-actions bot added the documentation Documentation label Feb 19, 2021
@aardappel
Copy link
Collaborator

Thanks!

@aardappel aardappel merged commit e2f5438 into google:master Feb 19, 2021
@mustiikhalil mustiikhalil deleted the swift-grammer branch February 19, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ codegen Involving generating code from schema documentation Documentation swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mustiikhalil @aardappel