Update PythonTest.sh #8393
Open
Update PythonTest.sh #8393
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow tests to complete as Python 2 does not support type-hinting, drop support for Python 2 per google#6329.
|
Unlike 4 years ago, I think we'd be fine dropping Python2 support at this point, wdyt @dbaileychess |
fliiiix
reviewed
Jan 16, 2025
| run_tests python2.6 100 100 100 100 false | ||
| run_tests python2.7 100 100 100 100 false | ||
| run_tests python2.7 100 100 100 100 true | ||
| # run_tests python2.6 100 100 100 100 false |
There was a problem hiding this comment.
i guess if it is decided to remove Python2 support this can be deleted and not just commented out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow tests to complete as Python 2 does not support type-hinting, drop support for Python 2 per #6329.