Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tree_multimap filterwarning once Jraph uses jax.tree_map instead of jax.tree_multimap #2037

Closed
marcvanzee opened this issue Apr 8, 2022 · 1 comment · Fixed by #2715
Closed

Remove tree_multimap filterwarning once Jraph uses jax.tree_map instead of jax.tree_multimap #2037

marcvanzee opened this issue Apr 8, 2022 · 1 comment · Fixed by #2715
Assignees
@marcvanzee
Labels
Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment.

Comments

@marcvanzee
Copy link
Collaborator

marcvanzee commented Apr 8, 2022 •
edited
Loading

Jraph uses jax.tree_multimap, which is deprecated and causes our tests to fail. Therefore I added a filterwarning in pytest.ini. We should remove this filter warning once Jraph fixes this.
@marcvanzee marcvanzee self-assigned this Apr 8, 2022
marcvanzee added a commit that referenced this issue Apr 8, 2022
@marcvanzee
Add filterwarning for jax.tree_multimap
d508e94 
See #2037
@marcvanzee marcvanzee mentioned this issue Apr 8, 2022
Merged
4 tasks
marcvanzee added a commit to marcvanzee/flax that referenced this issue Apr 8, 2022
@marcvanzee
Add filterwarning for jax.tree_multimap
4924a24 
See google#2037
marcvanzee added a commit to marcvanzee/flax that referenced this issue Apr 8, 2022
@marcvanzee
# This is a combination of 5 commits.
37312e1 
# This is the 1st commit message:

Adds Flax logo to README.md

# This is the commit message google#2:

Fix link

# This is the commit message google#3:

Add filterwarning for jax.tree_multimap

See google#2037
# This is the commit message google#4:

Update pytest.ini
# This is the commit message google#5:

Update pytest.ini
@andsteing andsteing added the Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment. label Apr 26, 2022
@marcvanzee marcvanzee changed the title Remove tree_multimap filterwarning once Optax releases a new version Remove tree_multimap filterwarning once Jraph releases a new version Jun 17, 2022
@marcvanzee
Copy link
Collaborator Author

marcvanzee commented Jun 17, 2022 •
edited
Loading

Update: Optax is fine now, but Jraph is still problematic. See google-deepmind/jraph#38

@marcvanzee marcvanzee changed the title Remove tree_multimap filterwarning once Jraph releases a new version Remove tree_multimap filterwarning once Jraph uses jax.tree_map instead of jax.tree_multimap Jun 17, 2022
@marcvanzee marcvanzee mentioned this issue Jun 17, 2022
Closed
@marcvanzee marcvanzee mentioned this issue Dec 12, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcvanzee marcvanzee

Labels
Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove some filterwarnings marcvanzee/flax
2 participants
@marcvanzee @andsteing