Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove flax.optim #2273

Closed
marcvanzee opened this issue Jul 7, 2022 · 2 comments
Closed

Remove flax.optim #2273

marcvanzee opened this issue Jul 7, 2022 · 2 comments
Assignees
@andsteing
Labels
Priority: P1 - soon Response within 5 business days. Resolution within 30 days. (Assignee required)

Comments

@marcvanzee
Copy link
Collaborator

flax.optim is deprecated and unused but we still have it around. We should remove it in a new version to not confuse new users.
@andsteing andsteing self-assigned this Jul 7, 2022
copybara-service bot pushed a commit that referenced this issue Jul 11, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
ac77231 
This fixes #2273

PiperOrigin-RevId: 459485412
@copybara-service copybara-service bot mentioned this issue Jul 11, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Jul 11, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
9c13635 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
67f8899 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
72cf73d 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
53f7eb9 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
6cacd68 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
8d07dee 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
4015c0f 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
a98ee2c 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
e5e6cbd 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
d6bca2d 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
41b3300 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 13, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
9005e39 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 13, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
0dbc7b3 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 13, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
7937427 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Jul 13, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
df9932d 
This fixes #2273

PiperOrigin-RevId: 459485412
@andsteing andsteing added the Priority: P1 - soon Response within 5 business days. Resolution within 30 days. (Assignee required) label Jul 26, 2022
@cgarciae cgarciae closed this as completed Aug 4, 2022
copybara-service bot pushed a commit that referenced this issue Aug 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
44d18c6 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Aug 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
9b7c8d3 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Aug 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
f98ca79 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Aug 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
7554c17 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Aug 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
cce392c 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Aug 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
1429f92 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Aug 12, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
9299e42 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Aug 15, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
4181bdb 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Aug 15, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
d5d6a9f 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Aug 15, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
80b4757 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Aug 15, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
1729e39 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Aug 15, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
4429d1a 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Aug 16, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
185cba5 
This fixes #2273

PiperOrigin-RevId: 459485412
copybara-service bot pushed a commit that referenced this issue Aug 16, 2022
@andsteing
Removes flax.optim & bumps version to 0.6.0
cda7a4c 
This fixes #2273

PiperOrigin-RevId: 467869152
@OhadRubin
Copy link

fyi, entirely removing the documentation makes updating code from flax.optim to optax harder since I don't know what anything in flax.optim does....

@andsteing
Copy link
Collaborator

Good point. Activated v0.5.3 for reference of flax.optim API:

https://flax.readthedocs.io/en/v0.5.3/flax.optim.html

(Make also sure to read the update guide, which is still available in the latest version: https://flax.readthedocs.io/en/latest/advanced_topics/optax_update_guide.html )

@JTorres258 JTorres258 mentioned this issue Aug 26, 2022
Open
copybara-service bot pushed a commit to google/fedjax that referenced this issue Sep 29, 2022
@jaehunro
Remove flax optim test now that flax.optim is deprecated in favor of …
61047c5 
…optax google/flax#2273

PiperOrigin-RevId: 477763323
@copybara-service copybara-service bot mentioned this issue Sep 29, 2022
Closed
copybara-service bot pushed a commit to google/fedjax that referenced this issue Sep 29, 2022
@jaehunro
Remove flax optim test now that flax.optim is deprecated in favor of …
180530a 
…optax google/flax#2273

PiperOrigin-RevId: 477787392
@Tkorsten Tkorsten mentioned this issue Aug 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andsteing andsteing

Labels
Priority: P1 - soon Response within 5 business days. Resolution within 30 days. (Assignee required)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes flax.optim & bumps version to 0.6.0 google/flax
4 participants
@marcvanzee @OhadRubin @cgarciae @andsteing