Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PReLU Activation #1570

Merged
merged 6 commits into from
Oct 28, 2021
Merged

Conversation

isaaccorley
Copy link
Contributor

What does this PR do?

Fixes #1419

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • This change is discussed in a Github issue/
    discussion (please add a
    link).
  • The documentation and docstrings adhere to the
    documentation guidelines.
  • This change includes necessary high-coverage tests.
    (No quality testing = no merge!)

@isaaccorley isaaccorley changed the title Activations/prelu Add PReLU Activation Sep 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #1570 (73b9e0c) into main (136f41a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1570      +/-   ##
==========================================
+ Coverage   83.07%   83.10%   +0.02%     
==========================================
  Files          69       69              
  Lines        5826     5836      +10     
==========================================
+ Hits         4840     4850      +10     
  Misses        986      986              
Impacted Files Coverage Δ
flax/linen/__init__.py 100.00% <ø> (ø)
flax/linen/activation.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 136f41a...73b9e0c. Read the comment docs.

Copy link
Member

@jheek jheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I just have 2 small comments

flax/linen/activation.py Outdated Show resolved Hide resolved
flax/linen/activation.py Outdated Show resolved Hide resolved
flax/linen/activation.py Outdated Show resolved Hide resolved
Copy link
Member

@jheek jheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Looks good to me!

@copybara-service copybara-service bot merged commit 004a118 into google:main Oct 28, 2021
@isaaccorley isaaccorley deleted the activations/prelu branch October 28, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PReLU activation implementation
3 participants