Fixes RST link formatting. #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, "source formatted" links like see [`optax`](https://optax.readthedocs.io/) are not supported in RST: - spatialaudio/nbsphinx#301 - https://docutils.sourceforge.io/FAQ.html#is-nested-inline-markup-possible So removing the "source formatting" so these links render as normal text (but with correct link formatting) in both Colab and RTD.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
8bitmp3
requested changes
Oct 18, 2021
There was a problem hiding this comment.
lgtm @andsteing
Lines 298-299 - maybe also remove the backticks in Module.apply?
"Create a function that evaluates your model on the test set with\n",
- "[`Module.apply`](https://flax.readthedocs.io/en/latest/flax.linen.html#flax.linen.Module.apply)"
+ "[Module.apply](https://flax.readthedocs.io/en/latest/flax.linen.html#flax.linen.Module.apply)"
|
@8bitmp3 good catch, removed those as well... |
jheek
added
the
Priority: P2 - no schedule
marcvanzee
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, "source formatted" links like
see
optaxare not supported in RST:
So removing the "source formatting" so these links render as normal text (but
with correct link formatting) in both Colab and RTD.
This will close overdue #659