Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Filter a Collection instead of a Container #1815

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

NeilGirdhar
Copy link
Contributor

This is a minor change to repair an error in the definition of FIlter: Container is not Sized, but needs to be for len to work. It should probably have been a typing.Collection.

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • This change is discussed in a Github issue/
    discussion (please add a
    link).
  • The documentation and docstrings adhere to the
    documentation guidelines.
  • This change includes necessary high-coverage tests.
    (No quality testing = no merge!)

@codecov-commenter
Copy link

Codecov Report

Merging #1815 (a21204f) into main (addfe9c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1815   +/-   ##
=======================================
  Coverage   83.17%   83.17%           
=======================================
  Files          69       69           
  Lines        5974     5974           
=======================================
  Hits         4969     4969           
  Misses       1005     1005           
Impacted Files Coverage Δ
flax/core/scope.py 89.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update addfe9c...a21204f. Read the comment docs.

Copy link
Member

@jheek jheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@copybara-service copybara-service bot merged commit 7288ada into google:main Jan 26, 2022
@NeilGirdhar NeilGirdhar deleted the container branch January 26, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants