-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tabulate #2316
Improve tabulate #2316
Conversation
70a9de8
to
be7133b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2316 +/- ##
==========================================
+ Coverage 69.33% 70.00% +0.67%
==========================================
Files 63 63
Lines 5556 5664 +108
==========================================
+ Hits 3852 3965 +113
+ Misses 1704 1699 -5 ☔ View full report in Codecov by Sentry. |
9f9ced0
to
a39eeca
Compare
b4c6ad8
to
3eeb4d6
Compare
b3cfbb3
to
0f23533
Compare
4316d48
to
8148149
Compare
fcf75e8
to
c50aa28
Compare
f0ee757
to
b1025cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
@jheek Something seems to have gone wrong with this PR internally, could you please take a look? |
What does this PR do?
Overhauls
tabulate
with a new system to capture call information and fixes #2274 and #2359.Changes
_CallInfoContext
context manager that provides richer call information.module
: shows module typeinputs
: shows input informationexclude_methods
arguments, it is no longer necessary ascapture_intermediates
is no longer used.nn.tabulate
results inKeyError: 'intermediates'
with methods that include transformations #2274 as collecting summaries no longer depends on any variables collection.show_repeated
arguments is added, lets you decide if you want to show repeated modules in case the same module is called multiple times.console_kwargs
argument that lets users configure therich.console.Console
object used to render the table.Future issues
Some issues related to
Scope.path
where uncovered here, will post issues with a minimal repro in the near future. To get around these issues some temporal fixes where used, see TODOs associated with each issue.Scope.path
sometimes empty when a module is called more than once, see TODO.Scope.path
names sometimes don't match the variable structure, specific issue found when naming a lifted Module, see TODO.Sample