Add on_commit_callback to put the responsibility of renaming the directories on the users of the serialization library. This will also fix the GCS atomic rename issue where the users can write a success file when the commit is successful and check the existence of that file before deserialization.
#2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #2328 +/- ##
==========================================
- Coverage 74.83% 74.80% -0.04%
==========================================
Files 61 61
Lines 5460 5465 +5
==========================================
+ Hits 4086 4088 +2
- Misses 1374 1377 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. |
copybara-service
bot
force-pushed
the
test_462953638
branch
from
b89b0a8 to
9788547
Compare
copybara-service
bot
changed the title
on_commit_callback to put the responsibility of renaming the directories on the users of the serialization library. This will also fix the GCS atomic rename issue where the users can write a success file when the commit is successful and check the existence of that file before deserialization.
copybara-service
bot
force-pushed
the
test_462953638
branch
3 times, most recently
from
78ac6a3 to
db2f02b
Compare
…rectories on the users of the serialization library. This will also fix the GCS atomic rename issue where the users can write a success file when the commit is successful and check the existence of that file before deserialization. PiperOrigin-RevId: 463238200
copybara-service
bot
force-pushed
the
test_462953638
branch
from
db2f02b to
d6de016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
on_commit_callbackto put the responsibility of renaming the directories on the users of the serialization library. This will also fix the GCS atomic rename issue where the users can write a success file when the commit is successful and check the existence of that file before deserialization.