Simplify dynamic context #2388
Merged
Simplify dynamic context #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jheek
approved these changes
Aug 16, 2022
|
@jheek there is an internal error on this PR. |
cgarciae
added
the
Priority: P2 - no schedule
|
Internally the branch is tested against the latest version of main. The issue is thrown here: https://github.com/google/flax/blob/main/flax/linen/module.py#L183 but that method is missing in your PR because it is outdated. Can you rebase and fix the issue? |
cgarciae
force-pushed
the
simplify-dynamic-context
branch
from
5d87b2e
to
9ff36a1
Compare
|
@jheek fixed the merge issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
_DynamicContextnow inherits fromthreading.local, properties are converted to regular fields.