Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IncorrectPostInitOverrideError to capture incorrect post init overrides. #2535

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

copybara-service[bot]
Copy link

Added IncorrectPostInitOverrideError to capture incorrect post init overrides.

Additionally, re-factored runtime tests into helper method.

@google-cla
Copy link

google-cla bot commented Oct 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Merging #2535 (1520e6f) into main (e0de630) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2535      +/-   ##
==========================================
+ Coverage   79.44%   79.47%   +0.02%     
==========================================
  Files          49       49              
  Lines        5197     5204       +7     
==========================================
+ Hits         4129     4136       +7     
  Misses       1068     1068              
Impacted Files Coverage Δ
flax/errors.py 87.36% <100.00%> (+0.41%) ⬆️
flax/linen/module.py 92.71% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

…verrides.

Additionally, re-factored runtime tests into helper method.

PiperOrigin-RevId: 481769823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants