-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrap Module properties #2541
wrap Module properties #2541
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## main #2541 +/- ##
==========================================
+ Coverage 79.47% 79.55% +0.08%
==========================================
Files 49 49
Lines 5204 5249 +45
==========================================
+ Hits 4136 4176 +40
- Misses 1068 1073 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ca6c3e3
to
1afd873
Compare
d209640
to
fb84e83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thank you!
Just one Q: and forgive me since we talked about this before and I'm spacing, but just for posterity: why do we check for staticmethod
/classmethod
inside _get_local_descriptor_names
after excluding callables?
@levskaya curiously |
5a7ba97
to
b9ca59e
Compare
b9ca59e
to
dd2f459
Compare
Co-authored-by: Marcus Chiam marcus.chiam@hotmail.com
What does this PR do?
Fixes #2537. Adds wrappers for
property
attributes for Module primarily to catchAttributeError
s in order to give a better error message (see discussion in #2537). Implementation follows the same strategy for our current method wrapper but specializes it forproperty
s.