Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose module.merge_param in RTD and fix docstring #2680

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

marcvanzee
Copy link
Collaborator

@marcvanzee marcvanzee commented Dec 1, 2022

This is a function that we use in e.g. Dropout. I propose we expose it in RTD so we can refer to it from the Dropout guide.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #2680 (da47d3e) into main (7563d8f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2680      +/-   ##
==========================================
+ Coverage   81.14%   81.19%   +0.05%     
==========================================
  Files          51       53       +2     
  Lines        5488     5600     +112     
==========================================
+ Hits         4453     4547      +94     
- Misses       1035     1053      +18     
Impacted Files Coverage Δ
flax/linen/module.py 92.28% <100.00%> (-0.36%) ⬇️
flax/linen/partitioning.py 79.06% <0.00%> (-3.15%) ⬇️
flax/io.py 84.84% <0.00%> (-0.42%) ⬇️
flax/linen/linear.py 97.51% <0.00%> (ø)
flax/linen/__init__.py 100.00% <0.00%> (ø)
flax/linen/recurrent.py 100.00% <0.00%> (ø)
flax/training/lr_schedule.py 0.00% <0.00%> (ø)
flax/__init__.py 100.00% <0.00%> (ø)
flax/linen/spmd.py 85.59% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

flax/linen/module.py Outdated Show resolved Hide resolved
flax/linen/module.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@8bitmp3 8bitmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions. Thanks @marcvanzee

@IvyZX IvyZX assigned IvyZX and marcvanzee and unassigned IvyZX Dec 2, 2022
Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>
Copy link
Collaborator

@8bitmp3 8bitmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcvanzee

LGTM

@copybara-service copybara-service bot merged commit 4669ea0 into google:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants