Adds some more comments to scope.py #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcvanzee
force-pushed
the
scope-tests
branch
from
6d3ae22 to
bbc1951
Compare
marcvanzee
force-pushed
the
scope-tests
branch
from
bbc1951 to
0560627
Compare
Codecov Report
@@ Coverage Diff @@
## main #2743 +/- ##
=======================================
Coverage 81.22% 81.22%
=======================================
Files 53 53
Lines 5636 5636
=======================================
Hits 4578 4578
Misses 1058 1058
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
levskaya
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the code in
scope._mutable_collectionandscope.put_variableis actually quite intricate and wasn't explain well.