Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link CleanRL's PPO Implementation #2780

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

vwxyzjn
Copy link
Contributor

@vwxyzjn vwxyzjn commented Jan 9, 2023

What does this PR do?

Hello, this is an awesome repo! We really love using Flax at CleanRL to seed up our implementations. I was wondering if you'd be interested in linking our PPO implementation, which runs faster (1850% speedup) by using EnvPool, a library for fast parallelizing environments, jitting the entire rollout through EnvPool's XLA interface, storing data more efficiently, and jax.scan. Thanks for your consideration!

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • This change is discussed in a Github issue/
    discussion (please add a
    link).
  • The documentation and docstrings adhere to the
    documentation guidelines.
  • This change includes necessary high-coverage tests.
    (No quality testing = no merge!)

@marcvanzee
Copy link
Collaborator

Nice! @jheek

@codecov-commenter
Copy link

Codecov Report

Merging #2780 (a621fbe) into main (62617db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2780   +/-   ##
=======================================
  Coverage   81.22%   81.22%           
=======================================
  Files          53       53           
  Lines        5636     5636           
=======================================
  Hits         4578     4578           
  Misses       1058     1058           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jheek jheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@copybara-service copybara-service bot merged commit b00ea7b into google:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants