Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced zeros and ones initializers with zeros_init and ones_init builder functions #2807

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Jan 18, 2023

refactoring the code base to use zeros_init and ones_init, as a follow up from #2790.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@chiamp chiamp force-pushed the initializers_refactor branch from fe3466b to 304635a Compare January 18, 2023 07:42
@chiamp chiamp self-assigned this Jan 18, 2023
@chiamp chiamp requested a review from marcvanzee January 18, 2023 07:58
examples/linen_design_test/dense.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Merging #2807 (88046e5) into main (e51d017) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2807   +/-   ##
=======================================
  Coverage   81.23%   81.23%           
=======================================
  Files          53       53           
  Lines        5659     5659           
=======================================
  Hits         4597     4597           
  Misses       1062     1062           
Impacted Files Coverage Δ
flax/core/lift.py 96.06% <ø> (ø)
flax/core/nn/attention.py 13.47% <ø> (ø)
flax/core/nn/linear.py 42.85% <ø> (ø)
flax/core/nn/normalization.py 46.66% <ø> (ø)
flax/errors.py 85.58% <ø> (ø)
flax/linen/__init__.py 100.00% <ø> (ø)
flax/linen/transforms.py 94.14% <ø> (ø)
flax/linen/attention.py 95.96% <100.00%> (ø)
flax/linen/linear.py 97.51% <100.00%> (ø)
flax/linen/recurrent.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@copybara-service copybara-service bot merged commit afd4c9f into google:main Jan 18, 2023
copybara-service bot pushed a commit that referenced this pull request Jan 18, 2023
@chiamp chiamp deleted the initializers_refactor branch January 23, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants