Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve nn.map_variables docstrings #2818

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

cgarciae
Copy link
Collaborator

What does this PR do?

Fixes #2793. Improves the docstrings for nn.map_variables by expanding a bit the explanation, improving the example, and improving the argument descriptions. It also makes the example testable on CI.

Copy link
Collaborator

@chiamp chiamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@copybara-service copybara-service bot merged commit e54411d into google:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation for nn.map_variables
2 participants