Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notebook handling #2860

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Feb 9, 2023

What does this PR do?

Improves notebook handling in the following ways:

  • Adds missing skip-execution tags to cells that install dependencies.
  • Adds a check during CI that asserts that flax wasn't reinstalled by any notebook in case a contributor forgot to add skip-execution.
  • Adds the nbstripout pre-commit hook to delete environment and user metadata from the notebook.

@codecov-commenter
Copy link

Codecov Report

Merging #2860 (a4aaaec) into main (26d46e4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2860   +/-   ##
=======================================
  Coverage   81.32%   81.32%           
=======================================
  Files          55       55           
  Lines        5779     5779           
=======================================
  Hits         4700     4700           
  Misses       1079     1079           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cgarciae cgarciae requested a review from chiamp February 13, 2023 18:36
@cgarciae cgarciae changed the title check flax is running in editable mode Check that Flax is not reinstalled by notebooks during testing Feb 13, 2023
@cgarciae cgarciae self-assigned this Feb 13, 2023
@cgarciae cgarciae changed the title Check that Flax is not reinstalled by notebooks during testing Improve notebooks handling Feb 14, 2023
@cgarciae cgarciae changed the title Improve notebooks handling Improve notebook handling Feb 14, 2023
@copybara-service copybara-service bot merged commit 776582c into google:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants